Unable to increment using push button

[anilmanisingh]

#include <12F675.h>
//#device ADC=10
#fuses INTRC_IO,NOWDT,NOPUT,NOPROTECT,NOCPD,NOMCLR
#use delay(clock=4000000)
#define GP0 PIN_A0
#define GP1 PIN_A1
#define GP2 PIN_A2
#define GP3 PIN_A3
#define GP4 PIN_A4
#define GP5 PIN_A5

int seq=0;

void blink_seq(void)
{
switch(seq)
{
case 0:
{
output_high( GP1 ); // turn LED on
delay_ms( 450 ); // wait 150ms
output_low( GP1 ); // turn LED off
delay_ms( 450 ); // wait 150ms
break;
}
case 1:
{
output_high( GP1 ); // turn LED on
delay_ms( 300 ); // wait 150ms
output_low( GP1 ); // turn LED off
delay_ms( 300 ); // wait 150ms
break;
}
case 2:
{
output_high( GP1 ); // turn LED on
delay_ms( 150 ); // wait 150ms
output_low( GP1 ); // turn LED off
delay_ms( 150 ); // wait 150ms
}
}
}
void main()
{
while(TRUE)
{

if(!input(GP5))
seq++;
blink_seq();
}
}


Hello Everyone

I want the push button to change the case each time I press the button.
But it happens in three or fourth attempt.

Please help me to overcome this problem.

[Mike Walne]

Learn to use the code button, preserves your code layout and makes it more readable.
My compiler complains button1 is not defined and to your 'if/else if' in the push_button() routine.
So, I can't run your code.

What is supposed to happen as your variable seq advances beyond 2?

Mike

[oxo]

[oxo]

Lots of errors, As Mike said, the issue is seq, which will be incrementing very quickly in the main loop.

I would have thought seq should be incremented by the validated button press.

[anilmanisingh]

Thanks for your reply.

Actually I want to blink led differently each time I press the push button GP5.

My problem is I am unable to get it correctly.

Hi mike after 2 I want to start over gain from zero and continue unless i cut off the supply .

Also I have seen one off you post like below and I want to do the same.

As I understand it, what you want is:-

(1) Operate in mode1 till button pressed, then advance to mode2.
(2) Operate in mode2 till button pressed, then advance to mode3.
(3) Operate in mode3 till button pressed, then return to mode1.

Thanks for you comment.

Please have a look at the new code:

#include <12F675.h>
//#device ADC=10
#fuses INTRC_IO,NOWDT,NOPUT,NOPROTECT,NOCPD,NOMCLR
#use delay(clock=4000000)
#define GP0 PIN_A0
#define GP1 PIN_A1
#define GP2 PIN_A2
#define GP3 PIN_A3
#define GP4 PIN_A4
#define GP5 PIN_A5

int seq=0;

void blink_seq(void)
{
switch(seq)
{
case 0:
{
output_high( GP1 ); // turn LED on
delay_ms( 450 ); // wait 150ms
output_low( GP1 ); // turn LED off
delay_ms( 450 ); // wait 150ms
break;
}
case 1:
{
output_high( GP1 ); // turn LED on
delay_ms( 300 ); // wait 150ms
output_low( GP1 ); // turn LED off
delay_ms( 300 ); // wait 150ms
break;
}
case 2:
{
output_high( GP1 ); // turn LED on
delay_ms( 150 ); // wait 150ms
output_low( GP1 ); // turn LED off
delay_ms( 150 ); // wait 150ms
}
}
}
void main()
{
while(TRUE)
{

if(!input(GP5))
seq++;
blink_seq();
}
}


http://imageshack.com/a/img540/7086/NAT6IY.png

https://imageshack.com/i/f0NAT6IYp

[oxo]

If you can't be bothered to used the code button, I can't be bothered to read your code. I already formatted it for you once.

[Mike Walne]

You're another one editing code after you've had a response.
Then makes nonsense of our replies.

In your original code (which oxo very kindly and neatly formatted for you) there was a variable count which more or less did what you want seq to do.
You've edited that code so our comments are no longer valid.

I've glanced at your new code (that's all I'm prepared to do) and notice your push_button() routine has gone.
Produce something which handles your buttons, use the "code button", then someone will be able to help you.

Mike

[PCM programmer]

There are many ways to debounce a push-button. The program below
shows one way. Every time you push the button, you will increment the
count and it will be displayed in the terminal window (TeraTerm).
Example: